Add PWA icon back to repo; add link tag for iOS #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master
Update fork to match current master
- Copy old icon back into repository - Update path to icon from manifest file - Add link metadata tag for iOS PWA icon to workbench.html - Add link metadata tag for iOS PWA icon to login page
sr229
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
Currently the path to the app icon from
manifest.json404s; this icon was removed at some point from the repository. And so, when installing the web app from a browser (desktop or mobile), the app icon is absent. This update adds back the largest icon from a previous commit, and references it from manifest.json. The path to the icon includes thestatic/out/vs/server/src/mediadirectory, since not everything from that folder gets copied into the app root directory.Additionally, a
<link>tag (to enable iOS devices to also pick up the app icon) was added to both the mainworkbench.htmlfile and the login page.Is there an open issue you can link to?
#802 - Add apple-touch-icon for iPad webapp